Skip to content

test(query_executor): add GROUP BY tests#61

Merged
poyrazK merged 2 commits intomainfrom
feature/vectorized-groupby
Apr 23, 2026
Merged

test(query_executor): add GROUP BY tests#61
poyrazK merged 2 commits intomainfrom
feature/vectorized-groupby

Conversation

@poyrazK
Copy link
Copy Markdown
Owner

@poyrazK poyrazK commented Apr 23, 2026

Summary

Add GROUP BY tests to query_executor_tests.cpp:

  • Enhanced SelectWithGroupBy to verify actual aggregated values (A=30, B=5)
  • Added SelectWithGroupByCount test (COUNT with column)
  • Added SelectWithGroupByMinMax test (MIN/MAX aggregates)
  • Added SelectWithGroupByMultipleColumns test (multi-column GROUP BY with 4 groups)

Test plan

  • All 44 query_executor_tests pass

@poyrazK
test(query_executor): add GROUP BY tests
83cb5be 
- Enhance SelectWithGroupBy to verify actual aggregated values
- Add SelectWithGroupByCount test (COUNT with column)
- Add SelectWithGroupByMinMax test (MIN/MAX aggregates)
- Add SelectWithGroupByMultipleColumns test (multi-column GROUP BY)
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 23, 2026 •
edited
Loading

Warning

Rate limit exceeded

@github-actions[bot] has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 10 minutes and 33 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 10 minutes and 33 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2586175d-388d-46a2-8837-c23610180214

📥 Commits

Reviewing files that changed from the base of the PR and between d0140ec and 5fbc580.

📒 Files selected for processing (1)
  • tests/query_executor_tests.cpp
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/vectorized-groupby

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

poyrazK
poyrazK commented Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Owner Author

@poyrazK poyrazK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's okay to merge

@poyrazK poyrazK merged commit 574222c into main Apr 23, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@poyrazK